opencontainers / opencontainers/runc

Flaky test: TestFdLeaks

Open
#4,297 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
13.5k
Forks
2.3k
Avg merge
2d 8h
Merged PRs (30d)
30

Description

Description

From https://github.com/opencontainers/runc/actions/runs/9307874551/job/25620077978?pr=4290 (job is ubuntu-22.04, 1.21.x, -race):

=== RUN   TestFdLeaks
    exec_test.go:1759: extra fd 23 -> 
    exec_test.go:1762: found 1 extra fds after container.Run
--- FAIL: TestFdLeaks (0.22s)

This is the first time I see it.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with TestFdLeaks in exec_test.go, especially the reported lines 1759 and 1762, and try to reproduce it in the linked Ubuntu 22.04, 1.21.x, race job. Trace the extra file descriptor around container.Run; done means the test no longer reports an unexpected descriptor and remains reliable in the affected CI configuration.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.