opencontainers / opencontainers/runc
libcontainer/configs: mount.go is no longer OS agnostic
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 13.5k
- Forks
- 2.3k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 30
Description
libcontainer/configs build on Darwin now fails with the following two changes:
- https://github.com/opencontainers/runc/commit/9c444070ec7bb83995dbc0185da68284da71c554
- https://github.com/opencontainers/runc/commit/382eba4354d764aaffec82720c23ef429496acf9
We should make sure mount.go is split out for _linux and/or unsupported.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by inspecting libcontainer/configs/mount.go and the two referenced commits to identify the Darwin-incompatible changes. Check the libcontainer/configs build on Darwin, then separate the mount implementation for Linux and/or unsupported systems so the Darwin build succeeds.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- operating-systems
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100