opencontainers / opencontainers/runc

Store init state failure error message is using wrong variable

Open
#3,659 6 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

kind/bug
Dominant language
Go
Stars
13.5k
Forks
2.3k
Avg merge
2d 8h
Merged PRs (30d)
30

Description

https://github.com/opencontainers/runc/blob/main/libcontainer/process_linux.go#L551

The error message uses the err variable, but the error is stored in uerr. If an error occurs while updating the state, the resulting error message is not helpful:

runc create failed: unable to start container process: error during container init: unable to store init state: %!w(<nil>)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in libcontainer/process_linux.go at line 551 and inspect the error formatting used after storing the init state. Confirm which variable contains the update failure and ensure the resulting message reports that error instead of a nil formatting value. Done means the reported runc create error includes the underlying state-update failure.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.