opencontainers / opencontainers/runc
TestExecInTTY: execin_test.go:351: unexpected carriage-return in output
Open
Nobody has claimed this yet.
area/ci
- Dominant language
- Go
- Stars
- 13.5k
- Forks
- 2.3k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 30
Description
During the course of CI for #2411 I saw a single failure from Fedora32 on Vagrant (logs here):
=== RUN TestExecInTTY
TestExecInTTY: execin_test.go:351: unexpected carriage-return in output
--- FAIL: TestExecInTTY (0.14s)
It only happened once, and so I suspect some race in the code or in the test. The test code comes from #1146.
@cyphar maybe you could take a look?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with TestExecInTTY in execin_test.go around line 351 and review the linked Fedora32 CI logs. Reproduce the failure if possible, then determine whether the unexpected carriage-return comes from a race in the test or in the code it exercises. Done means the cause is identified and the intermittent failure is prevented or the test is corrected.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli, testing
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100