opencontainers / opencontainers/runc

Failed to set property TasksAccounting when using systemd as cgroup driver

Open
#2,096 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
13.5k
Forks
2.3k
Avg merge
2d 8h
Merged PRs (30d)
30

Description

Version

systemd version: 219-30.el7_3.9
kubernetes version: v1.14.4
CentOS: 7.2

What happens

kubelet failed to start with errors

Apr 19 11:20:09 kubelet[20002]: E0419 11:20:09.770078   20002 node_container_manager_linux.go:50] Failed to create ["kubepods"] cgroup
Apr 19 11:20:09 kubelet[20002]: F0419 11:20:09.770102   20002 kubelet.go:1359] Failed to start ContainerManager Cannot set property TasksAccounting, or unknown property.

In my case, the TasksAccounting is a read only property.

What expected

kubelet should start successfully even if TasksAccounting and TasksMaxs properties are not supported.

Other notes

TasksAccounting and TasksMaxs were introduced in systemd 227, and in CentOS systemd, it seems that these two properties are added after 219-30.el7_3.9. So, I'd like to know if it would be better to report warning instead of exit with error when TasksAccounting and TasksMaxs are not supported or readOnly.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The report names node_container_manager_linux.go and kubelet.go in the startup logs, but the repository is runc, so first verify whether the failure belongs here and locate the related cgroup handling. Check how the systemd versions described treat TasksAccounting and TasksMaxs. Done means the supported behavior for missing or read-only properties is defined and kubelet can start as described.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, linux
Domain
operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.