opencontainers / opencontainers/runc
runc update --resource missing pids-limit and l3-cache-schema
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 13.5k
- Forks
- 2.3k
- Avg merge
- 2d 8h
- Merged PRs (30d)
- 30
Description
While runc update supports --pids-limit and --l3-cache-schema options, the --resources argument seems to miss them.
USAGE:
runc update [command options] <container-id>
OPTIONS:
--resources value, -r value path to the file containing the resources to update or '-' to read from the standard input
The accepted format is as follow (unchanged values can be omitted):
{
"memory": {
"limit": 0,
"reservation": 0,
"swap": 0,
"kernel": 0,
"kernelTCP": 0
},
"cpu": {
"shares": 0,
"quota": 0,
"period": 0,
"realtimeRuntime": 0,
"realtimePeriod": 0,
"cpus": "",
"mems": ""
},
"blockIO": {
"weight": 0
}
}
Note: if data is to be read from a file or the standard input, all
other options are ignored.
Although runc update -r does try to retrieve and set the pids limit, it is not shown in the example resource file contents. And currently l3-cache-schema cannot be set this way, which might be ok since it is not part of specs.LinuxResources.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the runc update command's -r/--resources handling and compare its accepted resource format with the --pids-limit and --l3-cache-schema options. Verify how pids-limit is retrieved and applied, and determine whether l3-cache-schema should be supported despite not being part of specs.LinuxResources. Done means the documented input and actual behavior agree.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100