opencontainers / opencontainers/runc

Failure of attempting to delete a container that is not stopped

Open
#1,774 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Go
Stars
13.5k
Forks
2.3k
Avg merge
2d 8h
Merged PRs (30d)
30

Description

This is basically the same issue as the comment by @liangchenye.

According to the runtime spec, kill should be done by users before delete. However, runc delete actually implicitly kills the container. This is probably the reason why validation/delete.t in runtime-tools fails with an error message like

not ok 2 - attempting to delete a container that is not stopped MUST generate an error
{
  "reference": "https://github.com/opencontainers/runtime-spec/blob/v1.0.0/runtime.md#delete"
}

See also https://github.com/opencontainers/runtime-spec/issues/958.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the runc delete entry point and compare its behavior with the OCI runtime specification linked in the issue. Reproduce the case using runtime-tools' validation/delete.t, then verify that attempting to delete a running container produces the required error rather than implicitly killing it.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli, operating-systems
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.