conformance: Github action to point to tagged image

Open
#100 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
docker, github-actions, go
Domain
build-system, ci-cd

Research direction

Start at the GitHub Action step that runs make conformance-binary and inspect how conformance.Version is populated through the Go test build. Check the image build's handling of .git and the proposed build-argument approach. Done means the tagged image builds without Git metadata access and the conformance binary receives the intended version.

Written by the indexing model from the issue text.

Description

conformance

For some reason, Github action does not have access to the .git directory:

Step 5/9 : RUN make conformance-binary && mv output/conformance.test /conformance.test
 ---> Running in 66d264dd2646
fatal: not a git repository (or any of the parent directories): .git
cd conformance && \
	CGO_ENABLED=0 go test -c -o /go/src/github.com/opencontainers/distribution-spec/output//conformance.test \
		--ldflags="-X github.com/opencontainers/distribution-spec/conformance.Version="
go: downloading github.com/opencontainers/distribution-spec v1.0.0-rc0.0.20200108182153-219f20cbcfa1

Perhaps we use build args instead of relying on git?

Dominant language
Go
Stars
1.1k
Forks
260
Avg merge
3d 23h
Merged PRs (30d)
1

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from opencontainers/distribution-spec

All issues in opencontainers/distribution-spec

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.