openclimatefix / openclimatefix/quartz-api
Bug: Substation
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 10
- Forks
- 32
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 13
Description
Describe the bug
Two different routes proces slightly different forecast results
To Reproduce
Steps to reproduce the behavior:
- pull forecasts for on substation
- pull forecast for all substations at one timestamp
Expected behavior
They results for one substation and one timestamp should be the same
Additional context
- the pull forecast subation, gets the gsp data, rounds it, then scales to primary
- the all susbation routes, gets all the gsp forecast and then scales (no rounding)
Idea
- We should remove the round before it scales to primary substation (here)
- round both routes to 3 d.c.p
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at src/quartz_api/internal/backends/dataplatform/client.py:493 and compare the single-substation forecast route with the all-substations-at-one-timestamp route. Reproduce both requests for the same substation and timestamp, then verify that their results match and both routes round to three decimal places.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100