openclimatefix / openclimatefix/ocf-data-sampler
PVNetConcurrent but no `self.valid_t0_times`
Open
Nobody has claimed this yet.
bug
- Dominant language
- Python
- Stars
- 20
- Forks
- 43
- PR merge metrics
- No merged PRs in 30d
Description
Describe the bug
Ive got some generation values with some nans, but there is enough for some valid samples
To Reproduce
Steps to reproduce the behavior:
- init PVNetConcurrentDataset()
- tried to
get_sample - got error saying
self.valid_t0_timesdoesnt exist
Expected behavior
Get a sample
Additional context
- this is for nl site forecast app (1.4.14), CI passed, but perhaps no nans in generation data
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with PVNetConcurrentDataset initialization and the get_sample path, reproducing the failure with generation data containing NaNs. Trace where self.valid_t0_times is expected to be created; done means valid samples can be returned when enough generation values remain.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100