openclimatefix / openclimatefix/data-platform
Regions not points
Open
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 3
- Forks
- 1
- Avg merge
- 44m
- Merged PRs (30d)
- 2
Description
Verification
- I have searched the existing issues to ensure this feature has not already been requested.
Provide a detailed description of the proposed feature.
If the location is a region (not site), can we make sure the geometry is not a point(x,y,)
What is the motivation for the feature?
We have had DE and NL entered as points, and it causes some issues down the line
Outline a potential approach or solution (optional).
You could
- add type on locationtype (site/region)
- if region down allow point when
- if site, only allow point
This could be when adding a new location
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the code path for adding a new location and inspect how location geometry and locationtype are currently validated. Done means regions such as DE and NL cannot be stored as point geometries, while sites can still use points.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100