openbullet / openbullet/OpenBullet2

Store UTC dates in the DB

Open
#1,055 0 comments 0 reactions 1 assignee View on GitHub

@openbullet is already working on this.

Since Jul 10, 2024.

area:backend enhancement
Dominant language
C#
Stars
2.4k
Forks
602
PR merge metrics
No merged PRs in 30d

Description

Issue #1038 was resolved by converting date filters to local time, but this shouldn't be a long-term solution, since the database can be ported over through different timezones and, since we're not saving any timezone info, the date would not be valid anymore.

This needs to be resolved at the HitStorageService level in OpenBullet2.Core, saving the date as UTC. We need to consider the implications of this in other parts of the codebase (e.g., in the web and native client hits table display).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.