openbikesensor / openbikesensor/openbikesensor.github.io

Replace "Ideal Image Slider"

Open
#43 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

technical
Dominant language
HTML
Stars
29
Forks
37
PR merge metrics
No merged PRs in 30d

Description

Using the "alt" attribute for Ideal Image Slider leads to double captions (once a caption then the same text again) on images. The "title" attribute does not seem to work.

This comes from a code that is no longer maintained and was copied from this repo to iis-captions.js von assets/js/slider.

captionContent += '<div class="iis-caption-title">' + slide.getAttribute('title') + '</div>';

@opatut what should we do about it? Just commenting this line would fix the problem of duplicate titles, but using copy of a library that is unsupported since 2015 might involve other risks, too.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with assets/js/slider/iis-captions.js, especially the captionContent line shown in the issue, and compare it with the copied Ideal Image Slider implementation. Reproduce the image-caption behavior on the website, then determine whether removing that line is sufficient or whether the unsupported slider code needs broader replacement; done means captions no longer appear twice.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.