openai / openai/codex

Auto-review should not require additional confirmation after an explicit "commit and push" request

Open
#42,186 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement safety-check
Dominant language
Rust
Stars
125k
Forks
19.4k
PR merge metrics
PR metrics pending

Description

Summary

When a user explicitly tells Codex to commit and push, Auto-review still pauses the task and asks for confirmation before pushing to the resolved branch.

This confirmation is redundant and should be removed for ordinary non-force pushes.

Problem

There are two issues with the current behavior:

  1. commit and push is already explicit authorization

    The user has directly instructed Codex to push the commit. Resolving that instruction into git push origin <branch> should not require a second confirmation for the same action.

  2. A normal push is recoverable

    A non-force push does not rewrite or delete existing remote history. If the pushed change is wrong, it can be undone with a revert or a follow-up commit. It should therefore be treated as a routine Git operation, not as a destructive action requiring Auto-review.

Steps to reproduce

  1. Ask Codex to commit and push.
  2. Codex creates the commit.
  3. Codex attempts to push it to the current branch.
  4. Auto-review pauses and asks the user to confirm the push.

Expected behavior

After an explicit commit and push instruction, Codex should be allowed to perform a normal push to the current branch without additional confirmation.

Auto-review should only intervene when the push is actually destructive, such as a force push, history rewrite, or remote ref deletion.

Why this matters

commit and push is one of the most common development workflows. Requiring repeated confirmation for an action the user has already explicitly authorized adds friction and prevents Codex from completing routine tasks autonomously.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the Auto-review handling for the commit and push workflow and reproduce the confirmation before a normal push. Done means an explicit request can perform a non-force push to the current branch without another confirmation, while force pushes, history rewrites, and remote ref deletions still trigger review.

Written by the indexing model from the issue text.

Assessment

Tech stack
git, rust
Domain
cli, devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.