openSUSE / openSUSE/libzypp

download.min_download_speed timeout is too long

Open Beginner friendly
#751 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
128
Forks
90
Avg merge
6h 1m
Merged PRs (30d)
1

Description

Comments directly above the code, say the sane thing:

// default to 10 seconds at low speed

But code makes it wait a full minute at the low speed before triggering the threshold:

https://github.com/openSUSE/libzypp/blob/69bb768654b4bf676adf226fc5a6a4895069ee0d/zypp/zypp/media/MediaCurl.cc#L487

https://github.com/openSUSE/libzypp/blob/69bb768654b4bf676adf226fc5a6a4895069ee0d/zypp-logic/zypp-curl/ng/network/request.cc#L303

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the referenced code in zypp/zypp/media/MediaCurl.cc around line 487 and zypp-logic/zypp-curl/ng/network/request.cc around line 303, starting with how download.min_download_speed determines its timeout. Align the low-speed timeout with the nearby comment stating a 10-second default, then verify that the threshold triggers after the intended interval.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
tooling
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
82/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.