openSUSE / openSUSE/daps2docker

In d2d_runner, we don't properly check which commands support --stringparam

Open
#12 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Shell
Stars
5
Forks
3
PR merge metrics
No merged PRs in 30d

Description

d2d_runner allows adding --stringparams via a file listing them. Unfortunately, not all supported daps subcommands allow --stringparam, namely package-{pdf,html,src} and online-docs don't.

This is not currently a practical issue for docserv2 because it only uses pdf, html, single-html, and epub. It's also not an issue for anyone using daps2docker normally because the --stringparam thing is entirely unsupported there, only d2d_runner knows how to use that.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the d2d_runner entry point and trace how its --stringparam file is applied to daps subcommands. Confirm the handling of package-pdf, package-html, package-src, and online-docs; done means those commands are not given the unsupported option while supported commands still receive it.

Written by the indexing model from the issue text.

Assessment

Tech stack
shell
Domain
tooling
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.