open-telemetry / open-telemetry/weaver
Check that semconv referenced in `renamed_to` exists
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 486
- Forks
- 108
- Avg merge
- 3d 4h
- Merged PRs (30d)
- 40
Description
Let's say I write
- id: code.filepath
stability: development
....
deprecated:
reason: renamed
renamed_to: does.not.exist # this one does not exist
I don't get any error from the weaver, so I added a semconv policy into https://github.com/open-telemetry/semantic-conventions/pull/2047, which checks that:
- there is an attribute (metric/event/etc depending on what's deprecated) with this identity
- it's not deprecated
p2 is probably a preference and belongs in the semconv policy, but the p1 seems to belong in the weaver resolution process. We should try resolving it similarly to ref or extends and fail if it's not found.
So I think we should have p1 is weaver
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how the weaver resolves ref and extends references, then compare that path with deprecated.renamed_to. Verify the behavior against a semantic convention whose renamed target does not exist; done means the weaver reports an error for the missing identity while valid references continue to resolve.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100