open-telemetry / open-telemetry/opentelemetry-python
Update typing to follow pyright
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.6k
- Forks
- 1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 19
Description
Based on the work in this PR: https://github.com/open-telemetry/opentelemetry-python/pull/4425
It was determined that we make smaller PR's to update the typing to follow the pyright instead of mypy.
These smaller PR's will work towards the goal of eliminating mypy and switching permanently to pyright.
Objectives:
- Fix typing issues from the exclude list in follow-up small PRs
a. Based on more restrictions we can set those and then clean them up in small prs. - When the fix list for at least opentelemetry-api and opentelemetry-sdk/resources is done, we remove mypy from CI.
a. Once the small PRs are merged we can remove the ci stuff.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Read PR 4425 first, then inspect the typing exclude list and the opentelemetry-api, opentelemetry-sdk/resources, and CI configuration areas mentioned in the issue. The work is complete when the excluded typing issues are addressed in follow-up changes and the stated conditions for removing mypy from CI are met.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- ci-cd, tooling
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100