open-telemetry / open-telemetry/opentelemetry-python
Fix the cyclic imports
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.6k
- Forks
- 1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 19
Description
Imports like this should be fixed separately https://github.com/open-telemetry/opentelemetry-python/blob/36aaa84d17284de6c873eadc0b955d97fe06b07b/opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/__init__.py#L28-L29
It seems there is no good reason for this cyclic import other than hacky fix for docs build
Originally posted by @srikanthccv in https://github.com/open-telemetry/opentelemetry-python/pull/3533#discussion_r1398706341
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with opentelemetry-sdk/src/opentelemetry/sdk/metrics/_internal/export/init.py at lines 28–29 and inspect the surrounding import structure. Check how the imports support the documentation build; done means the cyclic import is removed without breaking that build or the metrics export package.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- observability
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100