open-telemetry / open-telemetry/opentelemetry-python
TC review of Metrics implementation vs spec matrix
Open
@jsuereth is already working on this.
Since Aug 24, 2022.
metrics
- Dominant language
- Python
- Stars
- 2.6k
- Forks
- 1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 19
Description
The OTel Python v1.12.0 release includes stable metrics API and SDK. We are hoping a TC member can review our implementation vs the spec matrix and point out if there is anything obviously missing.
cc @lzchen @ocelotl
Open Issues
- https://github.com/open-telemetry/opentelemetry-python/issues/3042
- https://github.com/open-telemetry/opentelemetry-python/issues/3043
Nits
.strip()seems unnecessary (and possibly identity-changing) here
Feedback to Specification
- Shutdown on Exit is not well specified, but is common between (at least) python + java. We should make sure this shows up in the specification.
- "Attribute keys" portion of Views specification is directly implemented in Python, while more flexible in Java, JavaScript. Python is closest to .NET but also .NET has some flexibility beyond the specification here. I think it's worth a discussion.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.