open-telemetry / open-telemetry/opentelemetry-python
Fork process models for metric batch reader do not work
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 2.6k
- Forks
- 1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 19
Description
and when a new process is not created (simply a new fork is created).
When does this happen?
One thing I am still thinking about is how do I do the same for PeriodicExportingMetricReader? Unlike tracing/logging where the events are received by processor, the PMR collects them with collect function. There is nothing like emit or on_start/on_end where I can check if the pids to see the fork hook is invoked and invoke if not.
Originally posted by @srikanthccv in https://github.com/open-telemetry/opentelemetry-python/issues/2277#issuecomment-1148999039
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with PeriodicExportingMetricReader and its collect function, then compare the fork handling used for tracing and logging processors. Determine how the metric reader should detect a changed process ID and reinitialize its process model; done means forked metric batch reading works without breaking the existing tracing and logging behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- observability-sre
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100