open-telemetry / open-telemetry/opentelemetry-python-contrib
Enable all the http server instrumentations to directly receive the excluded urls as a param
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 1.1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 16
Description
Initially fixed for fastapi, instead of forcing the user to read the excluded_urls from environment, the option of passing the list directly as an argument allows to leverage other mechanisms (config, settings files, reading from env somewhere else, etc).
Is your feature request related to a problem?
Currently, if I don't provide an environment variable, there is no way to exclude_urls. Cannot modify them programmatically either (not in a straightforward way)
Describe the solution you'd like
The instrumentations have an optional parameter excluded_urls to pass this explicitly, using the environment variable as fallback.
Additional context
Related to: https://github.com/open-telemetry/opentelemetry-python-contrib/issues/375
Fastapi PR: https://github.com/open-telemetry/opentelemetry-python-contrib/pull/486
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the FastAPI PR (#486) and related issue #375 to understand the existing excluded_urls behavior. Identify the other HTTP server instrumentations and their tests, then verify that each accepts an optional excluded_urls argument while retaining the environment variable as fallback.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- api, backend
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100