open-telemetry / open-telemetry/opentelemetry-python-contrib
confluent-kafka: simplify patching of Producer and Consumer
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 1.1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 16
Description
The current way of patching swaps the kafka classes with AutoInstrumented* versions, and then wrap their methods.
That has the drawback of not being able to patch (in tests at least) if these classes have already been imported. I guess we can patch the kafka classes directly as the other instrumentations usually do.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the current confluent-kafka instrumentation patching implementation and its tests, especially cases where Producer or Consumer was imported before patching. Compare the existing approach with other instrumentations that patch classes directly. Done means patching works for already-imported classes and the relevant tests pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- kafka, python
- Domain
- distributed-systems
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100