open-telemetry / open-telemetry/opentelemetry-python-contrib
instrumentation/urllib: limitation in capturing headers
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 1.1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 16
Description
The urllib instrumentation api is built on top of http.client. Some of the request headers are added in this lower layer and are opaque to the current urllib instrumentation. I don't think that's an issue for most of the people as the higher level libraries we already instrument should have a lot more usage.
An option would be instrument the http.client module instead that but then we are going to limit only to http/https protocols and we would have to be sure we are exporting the very same telemetry.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the urllib instrumentation and its underlying http.client interaction, focusing on which request headers and telemetry are currently visible. Compare the possible instrumentation boundaries and document whether the exported telemetry can remain consistent; done requires an agreed approach and corresponding tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100