open-telemetry / open-telemetry/opentelemetry-python-contrib

Error in `BaggageSpanProcessor` readme

Open
#3,618 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.1k
Forks
1.1k
Avg merge
4d 15h
Merged PRs (30d)
16

Description

https://github.com/open-telemetry/opentelemetry-python-contrib/blame/80c357bb16b42c76763d85441e53dd4f6087d6c5/processor/opentelemetry-processor-baggage/README.rst#L65

I think this is wrong - this predicate just checks whether the key begins with the literal string ^key.+, it doesn't perform any regex matching.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open processor/opentelemetry-processor-baggage/README.rst at line 65 and review the predicate description against its stated behavior. Correct the README so it does not imply regex matching when the key is checked against the literal string ^key.+; the issue is done when the documentation accurately describes the predicate.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.