open-telemetry / open-telemetry/opentelemetry-python-contrib
We should be able to check if changes in generate_workflows_lib affects core
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 1.1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 16
Description
Describe your environment
OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
Package version: (e.g., 0.46.0)
What happened?
I changed generate_workflows_lib here and tests were green, unfortunately it broke core because the new behaviour does not fit what core is doing. If we change .github/workflows/generate_workflows_lib we should probably run a new job that is checking out core and testing that the generation is not different than what was before. We can use the skip-generate-workflows to ignore any error if really we want a behavior change
Additional context
No response
Would you like to implement a fix?
None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with .github/workflows/generate_workflows_lib and inspect the workflow that currently runs its tests. Then examine how core is checked out and how skip-generate-workflows is used. Done means a job detects generation changes that break core while allowing intentional behavior changes to opt out.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- github-actions, python
- Domain
- build-system, ci-cd
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100