open-telemetry / open-telemetry/opentelemetry-python-contrib
Consider making share test base for testing AutoInstrumentation and "instruments" lists
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 1.1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 16
Description
What problem do you want to solve?
All instrumentations are lacking in thorough autoinstrumentation tests
Describe the solution you'd like
Consider taking the logic in [this pr](: https://github.com/open-telemetry/opentelemetry-python-contrib/pull/2860) and modularizing it to be easily used across all instrumentations. Make sure that a breaking change like this would still break the tests.
Describe alternatives you've considered
No response
Additional Context
No response
Would you like to implement a fix?
None
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the testing logic in PR #2860 and the breaking change in PR #2702. Determine how to modularize the shared logic for use across instrumentations, with tests that detect changes to autoinstrumentation and "instruments" lists.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- observability, testing
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100