open-telemetry / open-telemetry/opentelemetry-python-contrib
Define distro that is to be returned by default
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 1.1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 16
Description
This seems to make the default behavior to be "return the first distro if there is no selected distro. This is a behavior we want to avoid, if the distro is not specifically selected a default fixed distro should be returned. Maybe this is what happens because a default distro is always set as the first distro but this function does not make that very obvious.
Originally posted by @ocelotl in https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1823#discussion_r1213851135
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the discussion in PR #1823 and trace the function that selects a distro. Determine how selection behaves when no distro is specified; this is done when the behavior clearly returns a fixed default distro rather than whichever distro happens to be first.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100