open-telemetry / open-telemetry/opentelemetry-python-contrib
urllib3 PoolManger issue on pypy3 tests
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 1.1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 16
Description
There is an issue with the new urllib3 version(1.26.16) on pypy3, the test_basic_http_success_using_connection_pool test doesn't finish.
According to the urllib3 documentation the new version fixed:
Fixed thread-safety issue where accessing a PoolManager with many distinct origins
would cause connection pools to be closed while requests are in progress (#2954 <https://github.com/urllib3/urllib3/pull/2954>_)
It might be related to the HttpTestbase and to the HTTPServer thread.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with instrumentation/opentelemetry-instrumentation-urllib3/tests/test_urllib3_ip_support.py and run test_basic_http_success_using_connection_pool under PyPy3 with urllib3 1.26.16. Then inspect tests/opentelemetry-test-utils/src/opentelemetry/test/httptest.py and its HTTPServer thread for the hang; done means the test completes reliably on PyPy3.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100