open-telemetry / open-telemetry/opentelemetry-python-contrib

opentelemetry-bootstrap seems to ignore pyproject.toml

Open
#1,596 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

auto-instrumentation enhancement help wanted
Dominant language
Python
Stars
1.1k
Forks
1.1k
Avg merge
4d 15h
Merged PRs (30d)
16

Description

Running the tool with and without pyproject.toml makes no difference.

The tool seems to rely on the current virtualenv instead, which seems wrong because:

  • the dev dependencies cannot be distinguished from core dependencies
  • the system packages are scanned too, and there's sadly lots of crap there
  • 3rd party crud is scanned, e.g. if the system has ROS installed, that gets scanned too

I feel that current design just won't cut it, not since year 2020.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the behavior with and without pyproject.toml, then inspect how opentelemetry-bootstrap discovers dependencies from the current virtualenv. Done means the tool distinguishes project dependencies from dev, system, and unrelated third-party packages and uses pyproject.toml as intended.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.