open-telemetry / open-telemetry/opentelemetry-python-contrib
Prometheus Remote Write exporter names can have consecutive underscores
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 1.1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 16
Description
[One more requirement](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/metrics/data-model.md#prometheus-compatibility:~:text=the%20_%20character.-,Multiple%20consecutive%20_%20characters%20MUST%20be%20replaced%20with%20a%20single%20_%20character.,-The%20Unit%20of). Feel free to open an issue and either do in a follow up PR or I can mark it up for grabs.
Originally posted by @aabmass in https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1359#discussion_r993970317
The names & labels after going through string sanitization can have consecutive underscores. This can be fixed, but may require some restructure of the code to not clobber the __name__ label.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing the Prometheus Remote Write exporter's string-sanitization path and how it handles the __name__ label. Compare the resulting names and labels with the linked Prometheus compatibility requirement; done means consecutive underscores are collapsed without clobbering the __name__ label.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- prometheus, python
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100