open-telemetry / open-telemetry/opentelemetry-python-contrib
[instrumentation-system-metrics] implement `uninstrument()`
Open
Nobody has claimed this yet.
instrumentation
metrics
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 1.1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 16
Description
As per Leighton's comment:
I would assume uninstrument() would cause the automatic collection to stop? Perhaps add a TODO?
Originally posted by @lzchen in https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1012#discussion_r844151533
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the discussion in pull request #1012, especially Leighton's comment, and trace the instrumentation-system-metrics implementation from there. Clarify whether uninstrument() must stop automatic collection or only receive a TODO, then verify the chosen behavior with the relevant existing tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100