open-telemetry / open-telemetry/opentelemetry-python-contrib
[instrumentation-system-metrics] Remove labels configuration
Open
@pridhi-arora is already working on this.
Since Nov 15, 2022.
good first issue
help wanted
instrumentation
metrics
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 1.1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 16
Description
As per Aaron's comment, the labels configuration parameter is no longer needed as views offer the same functionality.
It looks like this just adds extra attributes to all measurements. We should probably remove this?
We can do it in a separate PR though as this is just restoring the package
Originally posted by @aabmass in https://github.com/open-telemetry/opentelemetry-python-contrib/pull/1012#discussion_r843282052
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.