open-telemetry / open-telemetry/opentelemetry-python-contrib
[instrumentation-system-metrics] add support for pypy3
@rahulhacker is already working on this.
Since Jun 2, 2023.
- Dominant language
- Python
- Stars
- 1.1k
- Forks
- 1.1k
- Avg merge
- 4d 15h
- Merged PRs (30d)
- 16
Description
Some of the metrics gathered in opentelemetry-instrumentation-system-metrics are different in pypy3. For example, the following method fails on pypy3:
module 'gc' has no attribute 'get_count'
Instead, getting counts for garbage collection is done via GC hooks. See the following for more details:
https://doc.pypy.org/en/latest/gc_info.html
The work in this issue is to make the instrumentation either produce all the same metrics or exclude the instruments that don't have equivalents. Ideally at the end of this issue, the tests for this instrumentation library will be enabled in tox for pypy3.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.