open-telemetry / open-telemetry/opentelemetry-php

update batch processors to emit otel semconv metrics

Open
#1,647 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

stale
Dominant language
PHP
Stars
912
Forks
232
Avg merge
7d 16h
Merged PRs (30d)
4

Description

Our SDK's BatchSpanProcessor and BatchLogRecordProcessor emit metrics about their internal state, eg otel.trace.span_processor.spans and otel.logs.log_processor.queue.usage.
Since #1633 has been merged we have some official semantic conventions that can be used.

We should:

  • use semconv where available
  • consider dropping or submitting new semconv's for metrics we emit that do not map to a semconv

See https://opentelemetry.io/docs/specs/semconv/otel/sdk-metrics/

This is not a breaking change in terms of API, but behaviourally different enough to go into SDK 2.x ?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with BatchSpanProcessor and BatchLogRecordProcessor and compare their emitted metrics, including otel.trace.span_processor.spans and otel.logs.log_processor.queue.usage, with the SDK metrics semantic conventions linked in the issue. Determine which metrics have matching conventions and document the remaining cases for possible new conventions; done means the processors use applicable semconv names without an API break.

Written by the indexing model from the issue text.

Assessment

Tech stack
php
Domain
observability
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.