open-telemetry / open-telemetry/opentelemetry-php
[Feature Request] Integrating Laravel with sqlcommenter
Nobody has claimed this yet.
- Dominant language
- PHP
- Stars
- 912
- Forks
- 232
- Avg merge
- 7d 16h
- Merged PRs (30d)
- 4
Description
Before opening a feature request against this repo, consider whether the feature should/could be implemented in the other OpenTelemetry client libraries. If so, please open an issue in opentelemetry-specification first.
This feature is implemented in python, django. And in the past there was a library for Laravel.
https://github.com/open-telemetry/opentelemetry-sqlcommenter/blob/main/docs/python/django/README.md/#installation
https://github.com/google/sqlcommenter/tree/master/php/sqlcommenter-php/packages/sqlcommenter-laravel
Is your feature request related to a problem?
It would be useful to add comments to the SQL.
https://github.com/open-telemetry/opentelemetry-php/issues/1345
Describe the solution you'd like
Integrating Laravel with sqlcommenter.
Describe alternatives you've considered
I'm currently forking and using the google repository.
https://github.com/moeyashi/sqlcommenter/tree/update-opentelemetry
Additional context
It's probably not something we'll implement right away.
I think we'll align our approach with other languages through discussions on https://github.com/open-telemetry/opentelemetry-specification/issues/3560 and https://github.com/open-telemetry/opentelemetry-sqlcommenter/issues/5.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing docs/python/django/README.md in opentelemetry-sqlcommenter and the referenced google/sqlcommenter PHP Laravel package. Follow the discussions in opentelemetry-specification#3560 and opentelemetry-sqlcommenter#5 to establish the cross-language approach; done requires an agreed Laravel integration aligned with that approach.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- laravel, php
- Domain
- backend, databases
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100