open-telemetry / open-telemetry/opentelemetry-java
Require severity in the EventLogger.builder()
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2.5k
- Forks
- 1k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 58
Description
The main idea is that now, even if users sets a "filter" on events with severity lower than "error" the implementation of the EventLogger.builder() cannot return a "No-op" builder and has to record all the data until "build()" is called because the severity is not known.
It would be amazing to require severity to be provided as early as possible (with the event name) so that we can return a "no-op" builder when we are confident the event will be dropped, and not have to store attributes, etc.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the EventLogger.builder() API and trace how event severity filtering is handled before build(). Define how severity is supplied with the event name, and verify that events certain to be dropped return a no-op builder without retaining attributes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100