open-telemetry / open-telemetry/opentelemetry-java
Stabilize ExtendedSpanBuilder APIs
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2.5k
- Forks
- 1k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 58
Description
The ExtendedSpanBuilder APIs have been around (in some form) for a while now. They were introduced on 12/7/23 in #6017 and existed in contrib previously. The APIs don't allow you to do anything new, but improve the ergonomics of certain common operations.
In #6497 I left a comment suggesting a change to the APIs I think we should consider prior to stabilization:
The only thing that gives me pause is the SpanCallable, SpanRunnable interfaces. Would be preferable if we didn't introduce our own functional interfaces and could use Callable, Runnable instead. I understand that we loose type safety over the exception type, but could be worthwhile to have an API with types from standard java users are familiar with.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading api/incubator/src/main/java/io/opentelemetry/api/incubator/trace/ExtendedSpanBuilder.java and the linked discussion in PR #6497. Evaluate whether SpanCallable and SpanRunnable should be replaced with standard Java Callable and Runnable before the APIs are stabilized. Done means the API decision is resolved and the stabilization work reflects it.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- api, backend-api-design
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100