open-telemetry / open-telemetry/opentelemetry-java

Can Sampler#shouldSample method add a param `InstrumentationScopeInfo`?

Open
#5,153 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

blocked:spec Feature Request
Dominant language
Java
Stars
2.5k
Forks
1k
Avg merge
3d 17h
Merged PRs (30d)
58

Description

Is your feature request related to a problem? Please describe.
We need the scope_name to judge if it needs sampler but this parameter does not exist yet.

Describe the solution you'd like
Add the InstrumentationScopeInfo param like this

  SamplingResult shouldSample(
      InstrumentationScopeInfo instrumentationScopeInfo,
      Context parentContext,
      String traceId,
      String name,
      SpanKind spanKind,
      Attributes attributes,
      List<LinkData> parentLinks);

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating Sampler#shouldSample, its implementations, and all callers, then inspect how InstrumentationScopeInfo is represented in the Java SDK. The change is complete when the parameter is consistently accepted through the sampling path and the affected tests and implementations are updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.