open-telemetry / open-telemetry/opentelemetry-java
Can Sampler#shouldSample method add a param `InstrumentationScopeInfo`?
Open
Nobody has claimed this yet.
blocked:spec
Feature Request
- Dominant language
- Java
- Stars
- 2.5k
- Forks
- 1k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 58
Description
Is your feature request related to a problem? Please describe.
We need the scope_name to judge if it needs sampler but this parameter does not exist yet.
Describe the solution you'd like
Add the InstrumentationScopeInfo param like this
SamplingResult shouldSample(
InstrumentationScopeInfo instrumentationScopeInfo,
Context parentContext,
String traceId,
String name,
SpanKind spanKind,
Attributes attributes,
List<LinkData> parentLinks);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating Sampler#shouldSample, its implementations, and all callers, then inspect how InstrumentationScopeInfo is represented in the Java SDK. The change is complete when the parameter is consistently accepted through the sampling path and the affected tests and implementations are updated.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100