open-telemetry / open-telemetry/opentelemetry-java

Attributes to identify services that are using remote sampling

Open
#4,860 8 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Feature Request
Dominant language
Java
Stars
2.5k
Forks
1k
Avg merge
3d 17h
Merged PRs (30d)
58

Description

Is your feature request related to a problem? Please describe.
Currently there is no clear way for the collector to identify all the services that are using remote sampling policy - based on Jaeger remote sampling. So if we have to implement an adaptive sampling policy generation at the tracing back-end, one has to monitor root span traffic pattern for all services & root operations and generate the sampling policy for all services. When there is huge number of services & root operations this can be a problematic

Describe the solution you'd like
Enhance the JaegerRemoteSampler class to add attributes to indicate that the service is leveraging remote sampling and also add additional attributes like the sampler type & param. In Jaeger this was achieved since the Probabilistic sampler used to add sampler.type & sampler.param attribute/tag - which is missing in all the samplers provided in the SDK.
Additionally, can we consider adding sampler.type & sampler.param for all the samplers available in the SD?. Currently I believe only RateLimitingSampler (from jaeger-remote-sampler sdk-extenstion) does that.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating JaegerRemoteSampler and the sampler implementations, then compare their behavior with RateLimitingSampler, which the issue identifies as the existing example. Clarify the attribute names and coverage for remote sampling, sampler type, and sampler parameter before defining completion and validation.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
observability
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.