open-telemetry / open-telemetry/opentelemetry-java
Jaeger remote sampler should not reinitialize Sampler when configuration hasn't changed
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2.5k
- Forks
- 1k
- Avg merge
- 3d 17h
- Merged PRs (30d)
- 58
Description
Currently jaeger-remote-sampler always reinitializes a sampler when reading configuration
This isn't great for stateful samplers like RateLimitingSampler, which lose their state every update even when no change was supposed to be made. And even if the rate changed without a change in strategy, we would expect the rate to be updated inline without losing other state such as leak level.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in sdk-extensions/jaeger-remote-sampler/src/main/java/io/opentelemetry/sdk/extension/trace/jaeger/sampler/JaegerRemoteSampler.java around line 93 and trace how remote configuration is applied. Check how unchanged strategy and rate updates affect RateLimitingSampler state. Done means avoiding unnecessary sampler reinitialization while applying legitimate configuration changes without losing state.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- observability
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100