open-telemetry / open-telemetry/opentelemetry-java-instrumentation

Fix context leaks in existing tests

Open
#3,916 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Java
Stars
2.6k
Forks
1.2k
Avg merge
2d 18h
Merged PRs (30d)
228

Description

This is a tracking issue to fix context leaks in existing tests for all instrumentations that currently have to disable the strict context check.

TODO:

  • hystrix-1.4/javaagent #14922
  • kotlinx-coroutines/javaagent #14923
  • rxjava-3.0/library #14924
  • rxjava-3.1/library #14924
  • zio-2.0/javaagent

Completed:

  • aws-sdk-1.11/javaagent-unit-tests #4366
  • akka-http-10.0/javaagent #13472
  • elasticsearch-transport-6.0/javaagent #4282
  • finatra-2.9/javaagent #4282
  • grpc-1.6/javaagent #4282
  • kubernetes-client-7.0/javaagent #3945
  • mongo-4.0/javaagent #4364
  • okhttp-3.0/javaagent #3925
  • play-ws-2.0/javaagent #4365
  • play-ws-2.1/javaagent #4365
  • play-2.6/javaagent #4282
  • pekko-http-1.0/javaagent #13435
  • reactor-netty-0.9/javaagent #4282
  • reactor-netty-1.0/javaagent #4282
  • ratpack-1.4/javaagent #4367
  • rxjava-2.0/javaagent #4282
  • rxjava-2.0/library #4282
  • rxjava-3.0/javaagent #4282
  • scala-executors/javaagent #4282
  • servlet-5.0/javaagent #3923
  • tomcat-10.0/javaagent #3923

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the zio-2.0/javaagent entry in the TODO and inspect its existing tests for the strict context check. Run the relevant test suite and identify the context leaks that require the check to be disabled. Done means the zio tests no longer need that exception and the full affected test suite passes.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.