open-telemetry / open-telemetry/opentelemetry-java-instrumentation

Review ignored HttpClientTest

Open
#2,155 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

area:tests bug
Dominant language
Java
Stars
2.6k
Forks
1.2k
Avg merge
2d 18h
Merged PRs (30d)
228

Description

A lot of subclasses of HttpClientTest ignore one or more tests. This leaves us blind to the actual problems with our instrumentations, where we don't support quite common cases, e.g. redirects. We should review and fix them all.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating HttpClientTest and its subclasses, then identify which tests are ignored and inspect the affected instrumentation test suites. Review the ignored cases, including redirects, and confirm that the relevant tests run successfully without ignored coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.