open-telemetry / open-telemetry/opentelemetry-java-instrumentation

Split Redis instrumentation into focused PR stacks

Open
#20,010 0 comments 0 reactions 1 assignee View on GitHub

@trask is already working on this.

Since Sep 7, 2026.

enhancement needs triage
Dominant language
Java
Stars
2.6k
Forks
1.2k
Avg merge
2d 18h
Merged PRs (30d)
228

Description

Is your feature request related to a problem? Please describe.

The Redis instrumentation work is spread across a large six-PR stack. The current layers are difficult to review because several of them combine multiple client families or library versions and exceed the desired 1,000–2,000 line review size.

Describe the solution you'd like

Use #20009 as the shared Redis target foundation, then replace the current stack with focused client- and version-specific PRs: Jedis targets by version with Jedis 2.x peers; Lettuce 4.x and 5.x target/peer stacks; separate Rediscala and Redisson target PRs; and Vert.x Redis 4.0 and 4.4.5+ layers. Keep each replacement PR below roughly 2,000 additions and close the superseded PRs after the replacement branches are established.

The superseded PRs are #19871, #19874, #19878, #19882, #19885, and #19886.

Describe alternatives you've considered

Keeping the existing stack would preserve the current branch structure but leave several PRs too large for focused review. Rewriting the entire change as one PR would be larger still.

Additional context

This work implements the database target and network peer guidance from open-telemetry/semantic-conventions#4058 and is part of #19899. The proposed replacement layers are approximately 0.4–1.7k additions each.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.