open-telemetry / open-telemetry/opentelemetry-java-instrumentation

Use a shared Redis span-name attributes getter

Open
#19,717 0 comments 0 reactions 1 assignee View on GitHub

@trask is already working on this.

Since Aug 20, 2026.

enhancement needs triage
Dominant language
Java
Stars
2.6k
Forks
1.2k
Avg merge
2d 18h
Merged PRs (30d)
228

Description

Is your feature request related to a problem? Please describe.

Several Redis instrumentations subclass their database attributes getter only to exclude db.namespace from span names. This requires otherwise final getters to support inheritance and duplicates the workaround across Lettuce, Jedis, and Vert.x Redis.

Describe the solution you'd like

Add an internal RedisSpanNameDbAttributesGetter that delegates the attributes needed for span naming while omitting db.namespace, then use it across the affected modules.

Describe alternatives you've considered

Keep the existing anonymous subclasses in each module.

Additional context

Follow-up to #19706 and review discussion.

Tip

React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.