open-telemetry / open-telemetry/opentelemetry-java-instrumentation

Extend SqlClientAttributesGetter in SQL-sanitizing database instrumentations

Open
#19,230 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement needs triage
Dominant language
Java
Stars
2.6k
Forks
1.2k
Avg merge
2d 18h
Merged PRs (30d)
228

Description

Is your feature request related to a problem? Please describe.

Some DbClientAttributesGetter implementations leverage SQL sanitization but do not extend SqlClientAttributesGetter. Changing their hierarchy while old database semantic conventions are supported would break legacy span names.

Describe the solution you'd like

After support for the old database semantic conventions is dropped, update the affected DbClientAttributesGetter implementations to extend SqlClientAttributesGetter.

Describe alternatives you've considered

Keep the current getter hierarchy until old database semantic convention support is removed.

Additional context

Follow-up from #12608. This work is blocked on dropping old database semantic conventions because it breaks old-semconv span names.

Tip

React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing follow-up issue #12608 and locating the affected DbClientAttributesGetter implementations that use SQL sanitization. Confirm that support for old database semantic conventions has been dropped, then update the applicable getter hierarchies and verify that legacy span names are no longer a compatibility constraint.

Written by the indexing model from the issue text.

Assessment

Tech stack
java, sql
Domain
databases, observability
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.