open-telemetry / open-telemetry/opentelemetry-java-instrumentation
spymemcached: capture command arguments in db query text
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2.6k
- Forks
- 1.2k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 228
Description
Describe the bug
spymemcached instrumentation currently records operation name (e.g. get, set) but does not capture command arguments into statement/query attributes.
As a result, telemetry misses key command context compared to other cache/db instrumentations (e.g. redis clients).
Steps to reproduce
--
Expected behavior
For memcached commands, capture argument context into query text with sanitization, aligned with existing patterns used by other instrumentations:
- collect command-relevant args
- sanitize sensitive values (e.g. values ->
?) - emit statement/query text attribute
Example expectations: get my-keyset my-key 3600 ?getBulk key1 key2
Actual behavior
db.operation.nameis present- command argument context is missing from
db.statement/db.query.text
Javaagent or library instrumentation version
2.27.0
Environment
JDK:
OS:
Additional context
No response
Tip
React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding +1 or me too, to help us triage it. Learn more here.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the spymemcached instrumentation and comparing its command handling with the existing Redis instrumentation patterns referenced in the issue. Done means command-relevant arguments appear in the statement/query text, sensitive values are sanitized, and examples such as get, set, and getBulk produce the expected context.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 52/100