open-telemetry / open-telemetry/opentelemetry-java-instrumentation
invokedynamic API promotion : jpmsModulesToOpen
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2.6k
- Forks
- 1.2k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 228
Description
This is part of #13031
We need to promote the ExperimentalInstrumentationModule#jpmsModulesToOpen to the InstrumentationModule interface.
We need to decide on using class FQN in map entry or use JavaModule instance, this may imply some limitations if the instrumentation can't easily access a class to get the module instance.
Also, maybe we could potentially generate this method implementation using muzzle, as if we find references in advice bytecode to classes that are in another module, at least if we can easily detect that.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with issue #13031 and compare ExperimentalInstrumentationModule#jpmsModulesToOpen with the InstrumentationModule interface. Determine whether map entries should use class FQNs or JavaModule instances, and assess whether Muzzle can generate the implementation from advice bytecode references. Done means the API design is decided and the method is promoted with the required implementation path.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Quiet
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100