open-telemetry / open-telemetry/opentelemetry-java-instrumentation
Determine what to do about ZIO instrumentation
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 2.6k
- Forks
- 1.2k
- Avg merge
- 2d 18h
- Merged PRs (30d)
- 228
Description
As discussed in the SIG meeting today, the ZIO instrumentation has some challenges. We have to disable strict context checking (see #3916) in the tests due to leaking context.
Some of the challenges with this instrumentation are documented here:
https://github.com/open-telemetry/opentelemetry-java/issues/5303
This instrumentation is also mentioned in this issue by the ZIO maintainers, where they consider the opentelemetry instrumentation to be broken:
https://github.com/zio/zio-telemetry/issues/1029
This issue to help track what to do: Is there a workaround we can recommend? Should we disable this instrumentation by default in 3.0? Should it be deprecated and removed entirely? Is there another way we could fix this?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the strict context-checking discussion in #3916 and the linked issues #5303 and zio-telemetry#1029. Inspect the ZIO instrumentation tests where strict checking is disabled. Done means documenting an agreed workaround or deciding whether to disable, deprecate, remove, or otherwise fix the instrumentation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- observability
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100