open-telemetry / open-telemetry/opentelemetry-java-contrib

ConsistentReservoirSamplingSpanProcessorTest is sporadically failing

Open
#1,602 4 comments 0 reactions 2 assignees View on GitHub

@PeterF778 is already working on this.

Since Dec 13, 2024.

bug component:consistent-sampling
Dominant language
Java
Stars
269
Forks
196
Avg merge
2d 7h
Merged PRs (30d)
38

Description

https://github.com/open-telemetry/opentelemetry-java-contrib/actions/runs/12319968072/job/34388221769

(the reason this didn't show up before is because we used to auto-retry tests)

> Task :consistent-sampling:test

ConsistentReservoirSamplingSpanProcessorTest > testConsistentSampling() FAILED
    java.lang.AssertionError: 
    Expecting actual:
      0.006596909041848287
    to be greater than:
      0.01
        at io.opentelemetry.contrib.sampler.consistent.TestUtil.verifyObservedPvaluesUsingGtest(TestUtil.java:72)
        at io.opentelemetry.contrib.sampler.consistent.ConsistentReservoirSamplingSpanProcessorTest.testConsistentSampling(ConsistentReservoirSamplingSpanProcessorTest.java:608)
        at io.opentelemetry.contrib.sampler.consistent.ConsistentReservoirSamplingSpanProcessorTest.testConsistentSampling(ConsistentReservoirSamplingSpanProcessorTest.java:663)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.